bamaer opened a new pull request, #9590:
URL: https://github.com/apache/hop/pull/9590

   Fixes #9284
   
   The text chunker now also redacts:
   
   - pipeline and workflow parameter defaults whose name looks like a credential
   - the value of a name/value entry whose name looks like a credential: 
project, environment, run configuration and unit test variables in metadata 
JSON; Set variables, Pipeline action parameters, Pipeline executor mappings and 
Add constants in transform and action XML
   - top-level values of flat metadata, such as a mail server connection's 
`password`. These were never redacted.
   
   Names are matched with the existing markers, so a parameter like 
`MAX_TOKENS` or `TOKEN_LIMIT` is redacted too.
   
   Tests:
   
   - Unit: additions to `HopPipelineXmlParserTest`, `HopWorkflowXmlParserTest`, 
`HopXmlSupportTest` and `HopMetadataJsonParserTest`.
   - IT: `0117-text-chunker-redaction` gets 5 new inputs. It fails on main and 
passes with this change (`run-tests-docker.sh PROJECT_NAME=transforms 
TEST_FILTER=main-0115-text-chunker.hwf`).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to