bamaer commented on code in PR #9590:
URL: https://github.com/apache/hop/pull/9590#discussion_r4640929999
##########
plugins/transforms/textchunker/src/main/java/org/apache/hop/pipeline/transforms/chunker/document/metadata/HopMetadataJsonParser.java:
##########
@@ -190,10 +197,14 @@ private static JsonNode redactSecrets(JsonNode node) {
while (names.hasNext()) {
fields.add(names.next());
}
+ boolean secretEntry = isSecretEntry(object, fields);
for (String field : fields) {
JsonNode value = object.get(field);
if (value != null && value.isValueNode()) {
String redacted = SecretRedaction.redact(field, value.asText());
+ if (secretEntry && SecretRedaction.isEntryValueKey(field) &&
!value.asText().isEmpty()) {
Review Comment:
Done: in JSON, `null` and booleans are kept, nested and top-level
(`nullsBooleansAndVariableReferencesAreKept`). Numbers are still redacted under
a secret name, because a PIN can be a number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]