[ 
https://issues.apache.org/jira/browse/HTRACE-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248795#comment-14248795
 ] 

Colin Patrick McCabe commented on HTRACE-18:
--------------------------------------------

in README.md:

{code}
225     ####Flume Receiver
226     htrace-flume provides the `SpanReceiver` implementation
227     which sends spans to Flume collector configured with Avro source.
{code}

Should say "JSON" here, not "Avro"

{code}
  String serializeToJson();
{code}
Would prefer to call this just "ToJson"

+1 once those are addressed.  Thanks, Long Zhou.

> Support flume receiver
> ----------------------
>
>                 Key: HTRACE-18
>                 URL: https://issues.apache.org/jira/browse/HTRACE-18
>             Project: HTrace
>          Issue Type: Improvement
>            Reporter: Long Zhou
>         Attachments: htrace-flume01.patch, htrace-flume02.patch
>
>
> Hi htrace devs,
> I have been using htrace for a while and find it very useful.
> I needed a way to collect traces from remote servers via flume, so I 
> implemented the flume receiver (patch attached). If this code is useful to 
> other users, I would like to contribute it to the project.
> Please kindly review the patch, and let me know if anything I should 
> fix/improve.
> Thanks,
> Long Zhou



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to