[
https://issues.apache.org/jira/browse/HTRACE-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masatake Iwasaki updated HTRACE-148:
------------------------------------
Attachment: HTRACE-148.002.patch
Thanks for the comment, [~cmccabe].
bq. Maybe we should change all the import statements to refer to our shaded
versions, just to be sure.
We do not need to and maybe should not refer to relocated classes in general
but the problem is that {{MilliSpan.MilliSpanDeserializer}} can not be handled
by unshaded jackson classes at compile phase because it bacame a subclass of
{{org.apache.htrace.fasterxml.jackson.databind.annotation.JsonDeserialize}} as
a result of shading.
Another option is adding deserialization utility to htrace-core side as did in
002.
> TestHTracedRESTReceiver should use the shaded ObjectMapper to avoid
> TestHTracedRESTReceiver failure
> ---------------------------------------------------------------------------------------------------
>
> Key: HTRACE-148
> URL: https://issues.apache.org/jira/browse/HTRACE-148
> Project: HTrace
> Issue Type: Bug
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Fix For: 3.2.0
>
> Attachments: HTRACE-148.001.patch, HTRACE-148.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
