[
https://issues.apache.org/jira/browse/HTRACE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710262#comment-14710262
]
stack commented on HTRACE-214:
------------------------------
Add this change to release notes on this JIRA?
46 public static final String PATH_KEY = "local.file.span.receiver.path";
47 public static final String CAPACITY_KEY =
"local.file.span.receiver.capacity";
private final static String DEFAULT_PACKAGE = "org.apache.htrace.core";
On commit, add back the builder class comments. You removed them when you made
the builders internal classes. Or, looking at SpanReceiver.java, its javadoc is
wrong now? Referring to a Buiilder that has been moved internal? Needs update?
For consistency, TracerBuilder should be a Builder in Tracer? Would have to
update the doc in .md too.
Nice cleanup of doc.
I think this patch should go in. +1. It has a load of great stuff in it. More
review can come after I start using it hooking up hbase to use the new API.
Can address the above comments on commit.
> De-globalize Tracer.java
> ------------------------
>
> Key: HTRACE-214
> URL: https://issues.apache.org/jira/browse/HTRACE-214
> Project: HTrace
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-214.001.patch, HTRACE-214.002.patch,
> HTRACE-214.003.patch, HTRACE-214.004.patch, HTRACE-214.005.patch,
> HTRACE-214.006.patch, HTRACE-214.007.patch, HTRACE-214.008.patch
>
>
> De-globalize Tracer.java.
> Currently, Tracer is a Singleton managed by TracerHolder. Instead, Tracer
> objects should be created by each process or library that needs to use
> HTrace. This enables a few things:
> * When the Tracer object is created, we can give it a name. Then we can use
> this name in the "process id" of all spans created by that tracer, rather
> than trying to scrape the JVM name using "questionable" methods.
> * SpanReceivers can be shared between multiple Tracer objects in the same
> process. The span receivers are reference counted. This should eliminate
> the "double tracing" issues we have had when tracing client libraries inside
> processes which also want tracing.
> * Tracers can be closed by calling Tracer#close. If the Tracer being closed
> is the last tracer in the process, it will close all the span receivers.
> * We will have a TracerFactory that takes care of the details of creating the
> right span receivers based on the configuration. This removes some
> boilerplate that is currently needed to enable HTrace in an application or
> library. We can also make SpanReceiverFactory package-private since it will
> no longer need to be publicly visible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
