[
https://issues.apache.org/jira/browse/HTRACE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710508#comment-14710508
]
Hudson commented on HTRACE-214:
-------------------------------
FAILURE: Integrated in HTrace-Master #66 (See
[https://builds.apache.org/job/HTrace-Master/66/])
HTRACE-214. De-globalize Tracer.java (cmccabe) (cmccabe: rev
7997d208989b5e5bf6734da64ec9249c0226c21f)
* htrace-core/src/main/java/org/apache/htrace/core/ProbabilitySampler.java
* htrace-core/src/test/java/org/apache/htrace/core/TestSpanReceiverBuilder.java
* htrace-core/src/test/java/org/apache/htrace/core/TestHTrace.java
* htrace-core/src/main/java/org/apache/htrace/core/SpanReceiverBuilder.java
* htrace-zipkin/src/main/java/org/apache/htrace/impl/ZipkinSpanReceiver.java
*
htrace-core/src/test/java/org/apache/htrace/core/TestLocalFileSpanReceiver.java
* htrace-hbase/src/test/java/org/apache/htrace/impl/TestHBaseSpanReceiver.java
* htrace-core/src/main/java/org/apache/htrace/core/Span.java
* htrace-core/src/main/java/org/apache/htrace/core/TracerBuilder.java
* htrace-core/src/test/java/org/apache/htrace/core/TestNullScope.java
* htrace-core/src/main/java/org/apache/htrace/core/SamplerBuilder.java
* htrace-hbase/src/test/java/org/apache/htrace/impl/HBaseTestUtil.java
*
htrace-htraced/src/test/java/org/apache/htrace/impl/TestHTracedRESTReceiver.java
* htrace-flume/src/test/java/org/apache/htrace/impl/TestFlumeSpanReceiver.java
* htrace-core/src/main/java/org/apache/htrace/core/POJOSpanReceiver.java
* htrace-core/src/main/java/org/apache/htrace/core/NeverSampler.java
* htrace-core/src/test/java/org/apache/htrace/core/TestTracerId.java
* htrace-core/src/main/java/org/apache/htrace/core/LocalFileSpanReceiver.java
* htrace-core/src/test/java/org/apache/htrace/core/TestBadClient.java
* htrace-hbase/src/main/java/org/apache/htrace/HBaseSpanReceiverHost.java
* htrace-core/src/main/java/org/apache/htrace/core/NullScope.java
* htrace-flume/src/main/java/org/apache/htrace/impl/FlumeSpanReceiver.java
* htrace-hbase/src/main/java/org/apache/htrace/impl/HBaseSpanReceiver.java
* htrace-zipkin/src/test/java/org/apache/htrace/TestHTraceSpanToZipkinSpan.java
* htrace-core/src/test/java/org/apache/htrace/core/TestSampler.java
* htrace-core/src/main/java/org/apache/htrace/core/MilliSpan.java
* htrace-core/src/main/java/org/apache/htrace/core/TraceScope.java
* htrace-core/src/main/java/org/apache/htrace/core/SpanReceiver.java
* htrace-core/src/main/java/org/apache/htrace/core/Trace.java
* htrace-core/src/main/java/org/apache/htrace/core/TraceExecutorService.java
* htrace-core/src/main/java/org/apache/htrace/core/TraceRunnable.java
* htrace-core/src/main/java/org/apache/htrace/core/Tracer.java
* htrace-core/src/main/java/org/apache/htrace/core/TraceCallable.java
* htrace-htraced/src/main/java/org/apache/htrace/impl/HTracedRESTReceiver.java
* htrace-core/src/test/java/org/apache/htrace/core/TraceCreator.java
* htrace-core/src/main/java/org/apache/htrace/core/CountSampler.java
* htrace-core/src/main/java/org/apache/htrace/core/TracerId.java
* htrace-core/src/main/java/org/apache/htrace/core/SpanId.java
* htrace-core/src/main/java/org/apache/htrace/core/TracerPool.java
* htrace-core/src/main/java/org/apache/htrace/core/Sampler.java
* src/main/site/markdown/index.md
* htrace-core/src/main/java/org/apache/htrace/core/AlwaysSampler.java
* htrace-core/src/main/java/org/apache/htrace/core/TraceProxy.java
* htrace-core/src/main/java/org/apache/htrace/core/StandardOutSpanReceiver.java
> De-globalize Tracer.java
> ------------------------
>
> Key: HTRACE-214
> URL: https://issues.apache.org/jira/browse/HTRACE-214
> Project: HTrace
> Issue Type: Sub-task
> Affects Versions: 4.0
> Environment: release-notes: local-file-span-receiver.path
> configuration key changed to local.file.span.receiver.path for consistency
> local-file-span-receiver.capacity configuration key changed to
> local.file.span.receiver.capacity for consistency
> Default package for searching for SpanReceivers and Samplers was changed from
> org.apache.htrace.impl to org.apache.htrace.core.
> TracerId is now configured with % {tname} and similar, instead of ${tname}
> (to match the C client and make things easier when passing configuration
> through the shell.
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 4.0
>
> Attachments: HTRACE-214.001.patch, HTRACE-214.002.patch,
> HTRACE-214.003.patch, HTRACE-214.004.patch, HTRACE-214.005.patch,
> HTRACE-214.006.patch, HTRACE-214.007.patch, HTRACE-214.008.patch
>
>
> De-globalize Tracer.java.
> Currently, Tracer is a Singleton managed by TracerHolder. Instead, Tracer
> objects should be created by each process or library that needs to use
> HTrace. This enables a few things:
> * When the Tracer object is created, we can give it a name. Then we can use
> this name in the "process id" of all spans created by that tracer, rather
> than trying to scrape the JVM name using "questionable" methods.
> * SpanReceivers can be shared between multiple Tracer objects in the same
> process. The span receivers are reference counted. This should eliminate
> the "double tracing" issues we have had when tracing client libraries inside
> processes which also want tracing.
> * Tracers can be closed by calling Tracer#close. If the Tracer being closed
> is the last tracer in the process, it will close all the span receivers.
> * We will have a TracerFactory that takes care of the details of creating the
> right span receivers based on the configuration. This removes some
> boilerplate that is currently needed to enable HTrace in an application or
> library. We can also make SpanReceiverFactory package-private since it will
> no longer need to be publicly visible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
