[
https://issues.apache.org/jira/browse/HTRACE-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876676#comment-14876676
]
Hudson commented on HTRACE-85:
------------------------------
SUCCESS: Integrated in HTrace-Master #116 (See
[https://builds.apache.org/job/HTrace-Master/116/])
HTRACE-85 Feedback from Justin McClean over in general@incubator htrace RC vote
(stack: rev ee4eeaa3475a64a148bf6eda0090c85a52929cf2)
* NOTICE.txt
* LICENSE.txt
> Feedback from Justin McClean over in general@incubator htrace RC vote
> ---------------------------------------------------------------------
>
> Key: HTRACE-85
> URL: https://issues.apache.org/jira/browse/HTRACE-85
> Project: HTrace
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 4.0.1
>
> Attachments: 85.patch
>
>
> From Justin's feedback on the RC:
> {code}
> Minor LICENSE issues:
> While levigo is used it doesn't seem to be bundled so there's no need to add
> it to LICENSE. Same (I think) with kingpin, gorilla and godep. If it not
> bundled there's no need for it to mentioned in LICENSE. [1] Can you double
> check that there are bundled in the source release and if not remove their
> sections from LICENSE.
> Minor NOTICE issue:
> No need to have zipkin mentioned at it is Apache licensed and it's
> (incorrect) NOTICE file contains nothing that needs to be added here. [2]
> Slightly less minor NOTICE issue is that it is missing this text at the top:
> [3]
> Apache [PRODUCT_NAME]
> Copyright [XXXX-20XX] The Apache Software Foundation
> {code}
> Let me fix these before we do our next release (Justin was good w/ this).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
