[ 
https://issues.apache.org/jira/browse/HTRACE-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979797#comment-14979797
 ] 

Masatake Iwasaki commented on HTRACE-282:
-----------------------------------------

Thanks for the update. I got another errors while running {{TestQueries*}}. 
{{pruneExpired}} tried to use logger already closed.

{noformat}
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x48a023]

goroutine 52 [running]:
org/apache/htrace/htraced.(*shard).pruneExpired(0xc820610320)
        
/home/iwasakims/srcs/htrace/htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go:150
 +0x53
org/apache/htrace/htraced.(*shard).processIncoming(0xc820610320)
        
/home/iwasakims/srcs/htrace/htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go:144
 +0x81b
created by org/apache/htrace/htraced.CreateDataStore
        
/home/iwasakims/srcs/htrace/htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go:502
 +0x8b5
{noformat}

Reaper shold get logger as argument as Heartbeater do? Otherwise shd.store.lg 
could be used instead of shd.store.rpr.lg in {{pruneExpired}}.

{code}
func (shd *shard) pruneExpired() {
        lg := shd.store.rpr.lg
{code}


> htraced: reap spans which are older than a configurable interval
> ----------------------------------------------------------------
>
>                 Key: HTRACE-282
>                 URL: https://issues.apache.org/jira/browse/HTRACE-282
>             Project: HTrace
>          Issue Type: Bug
>          Components: htraced
>    Affects Versions: 3.2.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-282.001.patch, HTRACE-282.002.patch, 
> HTRACE-282.003.patch, HTRACE-282.004.patch, TestReapingOldSpans.log
>
>
> htraced: reap spans which are older than a configurable interval



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to