[ 
https://issues.apache.org/jira/browse/HTRACE-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014851#comment-15014851
 ] 

stack commented on HTRACE-302:
------------------------------

Don't want to do a constructor override, one that doesn't take testhooks?

-       hcl, err = htrace.NewClient(ht.ClientConf())
+       hcl, err = htrace.NewClient(ht.ClientConf(), nil)

You have to do a bunch of the above.

Where are these dbs getting created during tests?

+               DataDirs: make([]string, 2),

Otherwise, straight-forward patch.

+1 if it works for you.

> htraced: Add admissions control to HRPC to limit the number of incoming 
> messages
> --------------------------------------------------------------------------------
>
>                 Key: HTRACE-302
>                 URL: https://issues.apache.org/jira/browse/HTRACE-302
>             Project: HTrace
>          Issue Type: Bug
>          Components: htraced
>    Affects Versions: 4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-302.001.patch
>
>
> htraced: Add admissions control to HRPC to limit the number of incoming 
> messages.  This is important because if we bring in too many messages at 
> once, we'll end up using a huge (potentially unbounded) amount of memory when 
> we deserialize them.  Meanwhile, most messages can't be processed faster than 
> the datastore can handle them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to