[
https://issues.apache.org/jira/browse/HTRACE-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014893#comment-15014893
]
Colin Patrick McCabe commented on HTRACE-302:
---------------------------------------------
bq. Don't want to do a constructor override, one that doesn't take testhooks?
golang doesn't allow constructor overrides. I guess philosophically it's
similar to C, where you only have one function with a specific name (in a
specific package, at least).
bq. Where are these dbs getting created during tests?
They're under {{/tmp}}. Created by this code in {{mini_htraced.go}}
{code}
for idx := range bld.DataDirs {
if bld.DataDirs[idx] == "" {
bld.DataDirs[idx], err = ioutil.TempDir(os.TempDir(),
fmt.Sprintf("%s%d", bld.Name, idx+1))
if err != nil {
return nil, err
}
}
}
{code}
bq. +1 if it works for you.
thx
> htraced: Add admissions control to HRPC to limit the number of incoming
> messages
> --------------------------------------------------------------------------------
>
> Key: HTRACE-302
> URL: https://issues.apache.org/jira/browse/HTRACE-302
> Project: HTrace
> Issue Type: Bug
> Components: htraced
> Affects Versions: 4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-302.001.patch
>
>
> htraced: Add admissions control to HRPC to limit the number of incoming
> messages. This is important because if we bring in too many messages at
> once, we'll end up using a huge (potentially unbounded) amount of memory when
> we deserialize them. Meanwhile, most messages can't be processed faster than
> the datastore can handle them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
