VGalaxies commented on code in PR #2846:
URL:
https://github.com/apache/incubator-hugegraph/pull/2846#discussion_r2245650936
##########
hugegraph-server/hugegraph-dist/src/assembly/static/bin/init-store.sh:
##########
@@ -47,9 +47,16 @@ cd "${TOP}" || exit
DEFAULT_JAVA_OPTIONS=""
JAVA_VERSION=$($JAVA -version 2>&1 | awk 'NR==1{gsub(/"/,""); print $3}' | awk
-F'_' '{print $1}')
-# TODO: better not string number compare, use `bc` like
github.com/koalaman/shellcheck/wiki/SC2072
-if [[ $? -eq 0 && $JAVA_VERSION > "1.9" ]]; then
-
DEFAULT_JAVA_OPTIONS="--add-exports=java.base/jdk.internal.reflect=ALL-UNNAMED"
+
+# 提取主版本号进行数值比较
Review Comment:
please translate them into English~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
