imbajin commented on code in PR #2846:
URL:
https://github.com/apache/incubator-hugegraph/pull/2846#discussion_r2247160107
##########
hugegraph-server/hugegraph-dist/src/assembly/static/bin/init-store.sh:
##########
@@ -47,9 +47,16 @@ cd "${TOP}" || exit
DEFAULT_JAVA_OPTIONS=""
JAVA_VERSION=$($JAVA -version 2>&1 | awk 'NR==1{gsub(/"/,""); print $3}' | awk
-F'_' '{print $1}')
-# TODO: better not string number compare, use `bc` like
github.com/koalaman/shellcheck/wiki/SC2072
-if [[ $? -eq 0 && $JAVA_VERSION > "1.9" ]]; then
-
DEFAULT_JAVA_OPTIONS="--add-exports=java.base/jdk.internal.reflect=ALL-UNNAMED"
+
+# 提取主版本号进行数值比较
+if [[ $JAVA_VERSION == 1.* ]]; then
+ MAJOR_VERSION=$(echo $JAVA_VERSION | cut -d'.' -f2)
+else
+ MAJOR_VERSION=$(echo $JAVA_VERSION | cut -d'.' -f1)
+fi
+
+if [[ $? -eq 0 && $MAJOR_VERSION -ge 9 ]]; then
+
DEFAULT_JAVA_OPTIONS="--add-exports=java.base/jdk.internal.reflect=ALL-UNNAMED"
Review Comment:
这里的逻辑需要**更新**了, 现在是必须要求 Java 版本 == 11, 而不只是 Java9 之后了
所以麻烦修改一下这里的逻辑, 如果不符合请直接清晰的告诉用户需要使用 Java xx (这个抽取为一个变量, 方便后续升级 Java17/21
的时候直接调整即可, 避免硬编码了)
另外同时也看看 pd/store 的启动脚本里是否有版本检查, 一并可以同步一下, THX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
