imbajin commented on code in PR #418: URL: https://github.com/apache/incubator-hugegraph-doc/pull/418#discussion_r2385862002
########## themes/docsy/assets/scss/_variables.scss: ########## @@ -66,7 +66,7 @@ $link-hover-decoration: none !default; $google_font_name: "Open Sans" !default; $google_font_family: "Open+Sans:300,300i,400,400i,700,700i" !default; -$web-font-path: "https://fonts.googleapis.com/css?family=#{$google_font_family}&display=swap";; +// $web-font-path: "https://fonts.googleapis.com/css?family=#{$google_font_family}&display=swap";; // Disabled for self-hosted fonts Review Comment: **Should Fix**: Commented code should be removed instead of disabled Rather than commenting out the `$web-font-path` variable, it would be cleaner to remove it entirely since it's no longer needed with self-hosted fonts. Dead code comments can cause confusion for future maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
