imbajin commented on code in PR #418: URL: https://github.com/apache/incubator-hugegraph-doc/pull/418#discussion_r2385911494
########## themes/docsy/assets/scss/_variables.scss: ########## @@ -13,7 +13,7 @@ $enable-shadows: true !default; Review Comment: Critical: Avoid editing files under themes/. Set $td-enable-google-fonts: false in project override (assets/scss/_variables_project.scss) to prevent breakage on theme upgrades. Revert this change here and keep theme files pristine. ########## themes/docsy/assets/scss/_variables.scss: ########## @@ -66,7 +66,7 @@ $link-hover-decoration: none !default; Review Comment: Not necessary to comment out $web-font-path here if $td-enable-google-fonts: false is set via project override. Prefer keeping the theme file untouched and place overrides in assets/scss/_variables_project.scss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
