aokolnychyi commented on a change in pull request #398: Push down
StringStartsWith in Spark IcebergSource
URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317964972
##########
File path:
api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java
##########
@@ -355,4 +390,40 @@ public void testCaseInsensitiveIntegerNotEqRewritten() {
public void testCaseSensitiveIntegerNotEqRewritten() {
boolean shouldRead = new InclusiveMetricsEvaluator(SCHEMA, not(equal("ID",
5)), true).eval(FILE);
}
+
+ @Test
+ public void testStringStartsWith() {
+ boolean shouldRead = new InclusiveMetricsEvaluator(SCHEMA,
startsWith("required", "a"), true).eval(FILE);
+ Assert.assertTrue("Should read: no stats", shouldRead);
+
+ shouldRead = new InclusiveMetricsEvaluator(SCHEMA, startsWith("required",
"a"), true).eval(FILE_2);
+ Assert.assertTrue("Should read: range matches", shouldRead);
+
+ shouldRead = new InclusiveMetricsEvaluator(SCHEMA, startsWith("required",
"aa"), true).eval(FILE_2);
+ Assert.assertTrue("Should read: range matches", shouldRead);
+
+ shouldRead = new InclusiveMetricsEvaluator(SCHEMA, startsWith("required",
"aaa"), true).eval(FILE_2);
Review comment:
I'll add one. Actually, we don't truncate the prefix. For example, if the
upper bound is `3str3` and our prefix is `3str3abc`, then we cannot match,
right? Seems safe to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
