aokolnychyi commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r318107696
########## File path: spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java ########## @@ -153,6 +156,11 @@ public static Expression convert(Filter filter) { } return null; } + + case STARTS_WITH: { + StringStartsWith stringStartsWith = (StringStartsWith) filter; + return startsWith(stringStartsWith.attribute(), stringStartsWith.value()); + } Review comment: I've extended `TestFilteredScan` to verify this logic. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org