rdblue commented on a change in pull request #845: Add persistent IDs to
partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r406885812
##########
File path: core/src/main/java/org/apache/iceberg/PartitionSpecParser.java
##########
@@ -138,6 +140,7 @@ private static void
buildFromJsonFields(PartitionSpec.Builder builder, JsonNode
"Cannot parse partition spec fields, not an array: %s", json);
Iterator<JsonNode> elements = json.elements();
+ int fieldIdCnt = 0;
Review comment:
Nit: we like to avoid abbreviations that aren't readable. Saving a few chars
isn't worth trading readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
