rdblue commented on a change in pull request #845: Add persistent IDs to
partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r406889814
##########
File path: core/src/test/java/org/apache/iceberg/TestMergeAppend.java
##########
@@ -373,10 +374,10 @@ public void testChangedPartitionSpec() {
.bucket("id", 4)
.build();
- // commit the new partition spec to the table manually
- table.ops().commit(base, base.updatePartitionSpec(newSpec));
+ // commit the new partition spec to the table
+ table.updatePartitionSpec().update(newSpec).commit();
Review comment:
As I mentioned earlier, I think this should continue using the
`updatePartitionSpec` method so that we can add a public API for this in a
separate commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
