rdblue commented on a change in pull request #939:
URL: https://github.com/apache/incubator-iceberg/pull/939#discussion_r413194014
##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -93,7 +93,7 @@ public Transaction newCreateTableTransaction(
String baseLocation = location != null ? location :
defaultWarehouseLocation(identifier);
Map<String, String> tableProperties = properties != null ? properties :
Maps.newHashMap();
TableMetadata metadata = TableMetadata.newTableMetadata(schema, spec,
baseLocation, tableProperties);
- return Transactions.createTableTransaction(ops, metadata);
+ return Transactions.createTableTransaction(identifier.name(), ops,
metadata);
Review comment:
Did you mean to use `identifier.toString` here as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
