rdblue commented on a change in pull request #939: URL: https://github.com/apache/incubator-iceberg/pull/939#discussion_r413199808
########## File path: core/src/main/java/org/apache/iceberg/events/CreateSnapshotEvent.java ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.events; + +import java.util.List; +import java.util.Map; + + +public final class CreateSnapshotEvent { + private final String tableName; + private final String operation; + private final long snapshotId; + private final long sequenceNumber; + private final Map<String, String> summary; + private final List<String> addedFiles; + private final List<String> appendedManifests; + private final List<String> deletePaths; + + public CreateSnapshotEvent( + String tableName, String operation, long snapshotId, long sequenceNumber, Map<String, String> summary, + List<String> addedFiles, List<String> appendedManifests, List<String> deletePaths) { + this.tableName = tableName; + this.operation = operation; + this.snapshotId = snapshotId; + this.sequenceNumber = sequenceNumber; + this.summary = summary; + this.addedFiles = addedFiles; + this.appendedManifests = appendedManifests; + this.deletePaths = deletePaths; + } + + public String tableName() { + return tableName; + } + + public String operation() { + return operation; + } + + public long snapshotId() { + return snapshotId; + } + + public long sequenceNumber() { + return sequenceNumber; + } + + public Map<String, String> summary() { + return summary; + } + + public List<String> addedFiles() { + return addedFiles; + } + + public List<String> appendedManifests() { + return appendedManifests; + } + + public List<String> deletePaths() { Review comment: Minor: the other methods use past tense and refer to data files as "files", so this would be `deletedFiles()` right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
