jerqi commented on code in PR #8432:
URL: https://github.com/apache/iceberg/pull/8432#discussion_r1312411625
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -203,32 +203,46 @@ ManifestReader<F> scanMetrics(ScanMetrics newScanMetrics)
{
}
CloseableIterable<ManifestEntry<F>> entries() {
- if ((rowFilter != null && rowFilter != Expressions.alwaysTrue())
- || (partFilter != null && partFilter != Expressions.alwaysTrue())
- || (partitionSet != null)) {
+ return entries(false /* all entries */);
+ }
+
+ private CloseableIterable<ManifestEntry<F>> entries(boolean onlyLive) {
+ if (hasRowFilter() || hasPartitionFilter() || partitionSet != null) {
Review Comment:
Do we need to consider the condition
```
!partitionSet.isEmpty()
```
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -203,32 +203,46 @@ ManifestReader<F> scanMetrics(ScanMetrics newScanMetrics)
{
}
CloseableIterable<ManifestEntry<F>> entries() {
- if ((rowFilter != null && rowFilter != Expressions.alwaysTrue())
- || (partFilter != null && partFilter != Expressions.alwaysTrue())
- || (partitionSet != null)) {
+ return entries(false /* all entries */);
+ }
+
+ private CloseableIterable<ManifestEntry<F>> entries(boolean onlyLive) {
+ if (hasRowFilter() || hasPartitionFilter() || partitionSet != null) {
Review Comment:
Do we need to consider the condition?
```
!partitionSet.isEmpty()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
