aokolnychyi commented on code in PR #8432:
URL: https://github.com/apache/iceberg/pull/8432#discussion_r1313632181
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -266,12 +280,16 @@ private CloseableIterable<ManifestEntry<F>> open(Schema
projection) {
}
CloseableIterable<ManifestEntry<F>> liveEntries() {
- return CloseableIterable.filter(
- content == FileType.DATA_FILES
- ? scanMetrics.skippedDataFiles()
- : scanMetrics.skippedDeleteFiles(),
- entries(),
- entry -> entry != null && entry.status() !=
ManifestEntry.Status.DELETED);
+ return entries(true /* only live entries */);
+ }
+
+ private CloseableIterable<ManifestEntry<F>> filterLiveEntries(
Review Comment:
I did it this way so that I don't have to add `F extends ContentFile<F>` to
these static methods and reuse the bound already defined in the class. I could
use `?` in the second one but not here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
