ajantha-bhat commented on code in PR #8673:
URL: https://github.com/apache/iceberg/pull/8673#discussion_r1340280985
##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -49,7 +49,7 @@ public interface ManifestFile {
Types.LongType.get(),
"Lowest sequence number in the manifest");
Types.NestedField SNAPSHOT_ID =
- optional(
+ required(
Review Comment:
How do we maintain the compatibility of reading old manifestFiles?
The manifest reader will use new schema and try to read old file and it may
fail if the data was not written?
Are we sure we were always writing the data even for this optional field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
