Fokko commented on code in PR #8673:
URL: https://github.com/apache/iceberg/pull/8673#discussion_r1341369467
##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -49,7 +49,7 @@ public interface ManifestFile {
Types.LongType.get(),
"Lowest sequence number in the manifest");
Types.NestedField SNAPSHOT_ID =
- optional(
+ required(
Review Comment:
```
spark-sql ()> select * from examples.nyc_taxi_yellow limit 22;
23/09/29 15:28:54 WARN ObjectStore: Failed to get database global_temp,
returning NoSuchObjectException
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
2 2003-03-27 06:07:28 193 2003-03-27 22:30:46 193 1
0.0 1 1 3.31 2.5 0.01 0.0 0.5 0.3 0.0
0.0 N
2 2009-01-02 01:17:42 193 2009-01-02 18:19:52 193 1
0.0 1 1 0.0 0.0 0.0 0.0 0.0 0.0 0.0
0.0 N
2 2009-01-01 08:08:07 193 2009-01-01 08:08:12 193 1
0.0 1 2 3.3 2.5 0.0 0.0 0.5 0.3 0.0
0.0 N
2 2009-01-01 09:34:29 132 2009-01-01 09:52:13 203 1
4.99 1 2 17.3 16.0 0.0 0.0 0.5 0.3 0.0
0.5 N
2 2009-01-01 09:46:10 132 2009-01-01 10:16:52 39 2
9.36 1 2 29.3 28.5 0.0 0.0 0.5 0.3 0.0
0.0 N
2 2009-01-01 11:26:49 7 2009-01-01 23:37:23 7 1
0.0 1 2 0.0 0.0 0.0 0.0 0.0 0.0 0.0
0.0 N
2 2009-01-02 03:33:44 193 2009-01-02 03:34:54 193 1
0.0 1 2 0.0 0.0 0.0 0.0 0.0 0.0 0.0
0.0 N
2 2020-11-30 22:23:38 138 2020-12-01 21:44:12 116 1
8.64 1 1 37.92 26.5 4.0 6.12 0.5 0.3 0.0
0.5 N
NULL 2020-12-01 09:01:00 42 2020-12-01 09:08:00 41 NULL
1.4 NULL NULL 10.31 9.51 0.0 0.0 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:02:49 230 2020-12-01 09:34:29 61 NULL
9.69 NULL NULL 37.9 34.35 2.75 0.0 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:04:00 215 2020-12-01 09:07:00 215 NULL
0.51 NULL NULL 59.84 56.29 2.75 0.0 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:06:00 192 2020-12-01 09:27:00 70 NULL
3.83 NULL NULL 25.5 24.7 0.0 0.0 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:07:00 136 2020-12-01 09:21:00 243 NULL
3.03 NULL NULL 22.0 18.45 2.75 0.0 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:07:28 137 2020-12-01 09:23:35 69 NULL
8.09 NULL NULL 35.59 32.04 2.75 0.0 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:08:00 242 2020-12-01 09:25:00 18 NULL
4.55 NULL NULL 23.85 20.3 2.75 0.0 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:08:00 255 2020-12-01 09:24:00 146 NULL
4.74 NULL NULL 19.43 15.05 3.58 0.0 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:08:37 61 2020-12-01 09:36:29 137 NULL
9.79 NULL NULL 30.95 27.65 0.0 0.0 0.5 0.3 2.5
0.0 NULL
NULL 2020-12-01 09:09:00 168 2020-12-01 09:20:00 212 NULL
3.52 NULL NULL 25.5 21.95 2.75 0.0 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:12:10 140 2020-12-01 09:31:20 213 NULL
8.99 NULL NULL 34.82 19.03 2.75 12.24 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:14:00 239 2020-12-01 09:43:00 49 NULL
9.84 NULL NULL 36.36 28.85 4.21 0.0 0.5 0.3 2.5
0.0 NULL
NULL 2020-12-01 09:16:00 226 2020-12-01 09:41:00 219 NULL
14.79 NULL NULL 48.17 44.62 2.75 0.0 0.5 0.3 0.0
0.0 NULL
NULL 2020-12-01 09:24:00 140 2020-12-01 09:44:00 116 NULL
5.51 NULL NULL 30.08 21.9 4.88 0.0 0.5 0.3 2.5
0.0 NULL
Time taken: 16.631 seconds, Fetched 22 row(s)
```
##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -49,7 +49,7 @@ public interface ManifestFile {
Types.LongType.get(),
"Lowest sequence number in the manifest");
Types.NestedField SNAPSHOT_ID =
- optional(
+ required(
Review Comment:
It just works :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
