rdblue commented on code in PR #8683:
URL: https://github.com/apache/iceberg/pull/8683#discussion_r1348103716
##########
format/spec.md:
##########
@@ -167,30 +167,34 @@ A **`map`** is a collection of key-value pairs with a key
type and a value type.
#### Primitive Types
-| Primitive type | Description
| Requirements |
-|--------------------|--------------------------------------------------------------------------|--------------------------------------------------|
-| **`boolean`** | True or false
| |
-| **`int`** | 32-bit signed integers
| Can promote to `long` |
-| **`long`** | 64-bit signed integers
| |
-| **`float`** | [32-bit IEEE
754](https://en.wikipedia.org/wiki/IEEE_754) floating point | Can promote to
double |
-| **`double`** | [64-bit IEEE
754](https://en.wikipedia.org/wiki/IEEE_754) floating point |
|
-| **`decimal(P,S)`** | Fixed-point decimal; precision P, scale S
| Scale is fixed [1], precision must be 38 or less |
-| **`date`** | Calendar date without timezone or time
| |
-| **`time`** | Time of day without date, timezone
| Microsecond precision [2] |
-| **`timestamp`** | Timestamp without timezone
| Microsecond precision [2] |
-| **`timestamptz`** | Timestamp with timezone
| Stored as UTC [2] |
-| **`string`** | Arbitrary-length character sequences
| Encoded with UTF-8 [3] |
-| **`uuid`** | Universally unique identifiers
| Should use 16-byte fixed |
-| **`fixed(L)`** | Fixed-length byte array of length L
| |
-| **`binary`** | Arbitrary-length byte array
| |
+| Primitive type | Description
| Requirements |
+|----------------------|--------------------------------------------------------------------------|--------------------------------------------------|
+| **`boolean`** | True or false
| |
+| **`int`** | 32-bit signed integers
| Can promote to `long` |
+| **`long`** | 64-bit signed integers
| |
+| **`float`** | [32-bit IEEE
754](https://en.wikipedia.org/wiki/IEEE_754) floating point | Can promote to
double |
+| **`double`** | [64-bit IEEE
754](https://en.wikipedia.org/wiki/IEEE_754) floating point |
|
+| **`decimal(P,S)`** | Fixed-point decimal; precision P, scale S
| Scale is fixed [1], precision must be 38 or less |
+| **`string`** | Arbitrary-length character sequences
| Encoded with UTF-8 [2] |
+| **`uuid`** | Universally unique identifiers
| Should use 16-byte fixed |
+| **`fixed(L)`** | Fixed-length byte array of length L
| |
+| **`binary`** | Arbitrary-length byte array
| |
+| **`date`** | Calendar date, without time, without timezone
| [3] |
+| **`time`** | Time of day, without date, without timezone
| [3], [4] |
+| **`timestamp`** | Timestamp, with microsecond precision, without
timezone | [4], [6] |
+| **`timestamptz`** | Timestamp, with microsecond precision, with timezone
| [4], [7] |
+| **`timestamp_ns`** | Timestamp, with nanosecond precision, without
timezone | [5], [6] |
+| **`timestamptz_ns`** | Timestamp, with nanosecond precision, with timezone
| [5], [7] |
Review Comment:
We'll need to specify which types are allowed in different versions of the
spec. All of the original types are allowed from v1 forward. The new types
would need to be allowed from v3 forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
