aokolnychyi commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1372337825
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -157,11 +157,34 @@ public static ManifestWriter<DataFile>
write(PartitionSpec spec, OutputFile outp
*/
public static ManifestWriter<DataFile> write(
int formatVersion, PartitionSpec spec, OutputFile outputFile, Long
snapshotId) {
+ return write(formatVersion, spec, outputFile, snapshotId, null, null);
+ }
+
+ /**
+ * Create a new {@link ManifestWriter} for the given format version.
+ *
+ * @param formatVersion a target format version
+ * @param spec a {@link PartitionSpec}
+ * @param outputFile an {@link OutputFile} where the manifest will be written
+ * @param snapshotId a snapshot ID for the manifest entries, or null for an
inherited ID
+ * @param compressionCodec compression codec for the manifest file
+ * @param compressionLevel compression level of the compressionCodec
+ * @return a manifest writer
+ */
+ public static ManifestWriter<DataFile> write(
Review Comment:
I thought I already commented before going on vacation but can't seem to
find the old discussion. Sorry if I post the same question again. Have we
considered using a builder? My worry with the current approach was that we need
to offer an overloaded method every time we add a new parameter.
@wypoon @nastra @rdblue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
