aokolnychyi commented on code in PR #8928:
URL: https://github.com/apache/iceberg/pull/8928#discussion_r1374826073
##########
core/src/test/java/org/apache/iceberg/TestRewriteManifests.java:
##########
@@ -443,6 +444,14 @@ public void testBasicManifestReplacement() throws
IOException {
List<ManifestFile> manifests = snapshot.allManifests(table.io());
Assert.assertEquals(3, manifests.size());
+ if (formatVersion == 1) {
+
assertThat(manifests.get(0).path()).isNotEqualTo(firstNewManifest.path());
+
assertThat(manifests.get(1).path()).isNotEqualTo(secondNewManifest.path());
+ } else {
+ assertThat(manifests.get(0).path()).isEqualTo(firstNewManifest.path());
+ assertThat(manifests.get(1).path()).isEqualTo(secondNewManifest.path());
+ }
Review Comment:
There are actually two different tests. This one called basicReplacement and
tests the default behavior. The one below explicitly validates enabled snapshot
ID inheritance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
