aokolnychyi commented on code in PR #8928:
URL: https://github.com/apache/iceberg/pull/8928#discussion_r1377994540
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -337,7 +337,7 @@ private void replaceManifests(
addedManifests.forEach(rewriteManifests::addManifest);
commit(rewriteManifests);
- if (!snapshotIdInheritanceEnabled) {
+ if (formatVersion == 1 && !snapshotIdInheritanceEnabled) {
Review Comment:
I tried to generalize this in `SnapshotProducer`, I'd delay a utility call
like this until we have multiple use cases. It is a bit special as if format is
V2, the value must be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
