nastra commented on code in PR #8804:
URL: https://github.com/apache/iceberg/pull/8804#discussion_r1375068537
##########
aws/src/integration/java/org/apache/iceberg/aws/lakeformation/LakeFormationTestBase.java:
##########
@@ -357,8 +360,20 @@ String getRandomTableName() {
return LF_TEST_TABLE_PREFIX + UUID.randomUUID().toString().replace("-",
"");
}
- private static void waitForIamConsistency() throws Exception {
- Thread.sleep(IAM_PROPAGATION_DELAY); // sleep to make sure IAM up to date
+ private static void waitForIamConsistency(String roleName, String
policyName) {
+ // wait to make sure IAM up to date
+ Awaitility.await()
+ .pollDelay(Duration.ofSeconds(1))
+ .atMost(Duration.ofSeconds(10))
+ .until(
Review Comment:
this should do the same `untilAsserted()` check that I mentioned earlier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
