nastra commented on code in PR #8804:
URL: https://github.com/apache/iceberg/pull/8804#discussion_r1375072145
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##########
@@ -435,13 +437,11 @@ public void testConcurrentFastAppends(@TempDir File dir)
throws Exception {
for (int numCommittedFiles = 0;
numCommittedFiles < numberOfCommitedFilesPerThread;
numCommittedFiles++) {
- while (barrier.get() < numCommittedFiles * threadsCount) {
- try {
- Thread.sleep(10);
- } catch (InterruptedException e) {
- throw new RuntimeException(e);
- }
- }
+ final int currentFilesCount = numCommittedFiles;
+ Awaitility.await()
+ .pollInterval(Duration.ofMillis(10))
+ .pollInSameThread()
Review Comment:
then we need to figure out why the test was flaky. Was it occassionally
failing? The purpose of using Awaitility is to make tests more robust and less
flaky, so we need to figure out why this is flaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
