Xuanwo commented on code in PR #97:
URL: https://github.com/apache/iceberg-rust/pull/97#discussion_r1399106512
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -446,6 +490,24 @@ impl RestCatalog {
Ok(())
}
+
+ fn load_file_io(
+ &self,
+ metadata_location: Option<&str>,
+ extra_config: Option<HashMap<String, String>>,
+ ) -> Result<FileIO> {
+ let mut props = self.config.props.clone();
+ if let Some(config) = extra_config {
+ props.extend(config);
+ }
+
+ let file_io = match
self.config.warehouse.as_deref().or(metadata_location) {
+ Some(url) => FileIO::from_path(url)?.with_props(props).build()?,
+ None => FileIOBuilder::new("s3").with_props(props).build()?,
Review Comment:
> I would not expect to fallback to S3, and this might lead to unexpected
error messages.
I agree. We shouldn't favor specific storage services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
