Fokko commented on code in PR #97:
URL: https://github.com/apache/iceberg-rust/pull/97#discussion_r1404061539


##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -1017,31 +1109,31 @@ mod tests {
             .with_summary(Summary {
                 operation: Operation::Append,
                 other: HashMap::from_iter([
-                                          ("spark.app.id", 
"local-1646787004168"),
-                                          ("added-data-files", "1"),
-                                          ("added-records", "1"),
-                                          ("added-files-size", "697"),
-                                          ("changed-partition-count", "1"),
-                                          ("total-records", "1"),
-                                          ("total-files-size", "697"),
-                                          ("total-data-files", "1"),
-                                          ("total-delete-files", "0"),
-                                          ("total-position-deletes", "0"),
-                                          ("total-equality-deletes", "0")
-                ].iter().map(|p|(p.0.to_string(), p.1.to_string())))
+                    ("spark.app.id", "local-1646787004168"),

Review Comment:
   Why is this changed? It looks only indentation has changed, and most linters 
would not allow that since it makes the linter non-deterministic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to