amogh-jahagirdar commented on code in PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402845199
##########
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##########
@@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) {
ManageSnapshots replaceBranch(String name, long snapshotId);
/**
- * Replaces the branch with the given name to point to the source snapshot.
The source branch will
- * remain unchanged, the target branch will retain its retention properties.
+ * Replaces the source branch with the given name to point to the target
snapshot. The target
+ * branch will remain unchanged, the source branch will retain its retention
properties.
*
- * @param name Branch to replace
- * @param source Source reference for the target to be replaced with
+ * @param source Branch to replace
+ * @param target Target reference for the target to be replaced with
Review Comment:
Yeah@rdblue also suggested from and to. It sounded odd in combination with
`replace` but I'll update it, maybe it's more natural when reading as opposed
to how it sounds.
##########
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##########
@@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) {
ManageSnapshots replaceBranch(String name, long snapshotId);
/**
- * Replaces the branch with the given name to point to the source snapshot.
The source branch will
- * remain unchanged, the target branch will retain its retention properties.
+ * Replaces the source branch with the given name to point to the target
snapshot. The target
+ * branch will remain unchanged, the source branch will retain its retention
properties.
*
- * @param name Branch to replace
- * @param source Source reference for the target to be replaced with
+ * @param source Branch to replace
+ * @param target Target reference for the target to be replaced with
Review Comment:
Yeah I was discussing with @rdblue and he also suggested from and to. It
sounded odd in combination with `replace` but I'll update it, maybe it's more
natural when reading as opposed to how it sounds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
