nastra commented on code in PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#discussion_r1403006302
##########
core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java:
##########
@@ -106,40 +106,42 @@ public UpdateSnapshotReferencesOperation
replaceBranch(String name, long snapsho
return this;
}
- public UpdateSnapshotReferencesOperation replaceBranch(String name, String
source) {
- return replaceBranch(name, source, false);
+ public UpdateSnapshotReferencesOperation replaceBranch(
+ String branchToUpdate, String destination) {
Review Comment:
do we want to align this with the parameter naming in `ManageSnapshots
replaceBranch(String from, String to)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
