RussellSpitzer commented on code in PR #8755:
URL: https://github.com/apache/iceberg/pull/8755#discussion_r1409668358
##########
core/src/main/java/org/apache/iceberg/SystemConfigs.java:
##########
@@ -43,14 +43,14 @@ private SystemConfigs() {}
Integer::parseUnsignedInt);
/**
- * Sets the size of the delete worker pool. This limits the number of
threads used to compute the
- * PositionDeleteIndex from the position deletes for a data file.
+ * Sets the size of the delete worker pool. This limits the number of
threads used to read delete
+ * files for a data file.
*/
public static final ConfigEntry<Integer> DELETE_WORKER_THREAD_POOL_SIZE =
new ConfigEntry<>(
"iceberg.worker.delete-num-threads",
"ICEBERG_WORKER_DELETE_NUM_THREADS",
- Math.max(2, Runtime.getRuntime().availableProcessors()),
+ Math.max(2, 4 * Runtime.getRuntime().availableProcessors()),
Review Comment:
Not a huge deal but we are avoiding the RevCheck here by putting our
multiplier in a constant here. We should probably move the 4 into a field so
future modifications trigger the Rev checker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
