RussellSpitzer commented on code in PR #8755:
URL: https://github.com/apache/iceberg/pull/8755#discussion_r1409670268
##########
core/src/main/java/org/apache/iceberg/deletes/BitmapPositionDeleteIndex.java:
##########
@@ -27,6 +27,15 @@ class BitmapPositionDeleteIndex implements
PositionDeleteIndex {
roaring64Bitmap = new Roaring64Bitmap();
}
+ void merge(PositionDeleteIndex other) {
Review Comment:
Why not just only allow BitmapPositionDeleteIndex here? Do we not have the
type when we call merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
