Fokko commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411609064
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -91,7 +90,12 @@ public static void dropTableData(FileIO io, TableMetadata
metadata) {
Set<ManifestFile> manifestsToDelete = Sets.newHashSet();
for (Snapshot snapshot : metadata.snapshots()) {
// add all manifests to the delete set because both data and delete
files should be removed
- Iterables.addAll(manifestsToDelete, snapshot.allManifests(io));
+ try {
+ Iterables.addAll(manifestsToDelete, snapshot.allManifests(io));
+ } catch (RuntimeException e) {
Review Comment:
Should we make this one less wide? This might catch a lot of exceptions and
hide certain issues. How about using the KeyNotFoundException as mentioned in
the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
