nk1506 commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411645521
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -150,8 +154,7 @@ private static void deleteFiles(FileIO io,
Set<ManifestFile> allManifests) {
String type = reader.isDeleteManifestReader() ? "delete" :
"data";
deleteFiles(io, pathsToDelete, type, false);
} catch (IOException e) {
- throw new RuntimeIOException(
- e, "Failed to read manifest file: %s", manifest.path());
+ LOG.warn("Failed to read manifest file: {}", manifest.path(),
e);
Review Comment:
Only
[line](https://github.com/apache/iceberg/pull/9184/files#diff-eb6315ae857b4f8efb2c65b93e931432bba5a33b407ed60cf3b8c76f0277cda1R142)
can cause this IOException, which is only while reading. All the deleteFile
operations are catching related exception and handling it without throwing it
back.
IMO, here it should be error for read only. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
