lschetanrao commented on code in PR #9241:
URL: https://github.com/apache/iceberg/pull/9241#discussion_r1420858188
##########
mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java:
##########
@@ -63,7 +63,7 @@
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.iceberg.types.Types;
import org.apache.iceberg.util.ByteBuffers;
-import org.junit.Assert;
+import org.assertj.core.api.Assertions;
Review Comment:
done
##########
mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java:
##########
@@ -218,13 +218,12 @@ public static void assertEquals(Record expected, Record
actual) {
for (int i = 0; i < expected.size(); ++i) {
if (expected.get(i) instanceof OffsetDateTime) {
// For OffsetDateTime we just compare the actual instant
- Assert.assertEquals(
- ((OffsetDateTime) expected.get(i)).toInstant(),
- ((OffsetDateTime) actual.get(i)).toInstant());
+ Assertions.assertThat(((OffsetDateTime) actual.get(i)).toInstant())
+ .isEqualTo(((OffsetDateTime) expected.get(i)).toInstant());
} else if (expected.get(i) instanceof byte[]) {
- Assert.assertArrayEquals((byte[]) expected.get(i), (byte[])
actual.get(i));
+ Assertions.assertThat((byte[]) actual.get(i)).isEqualTo((byte[])
expected.get(i));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
