nastra commented on code in PR #9241:
URL: https://github.com/apache/iceberg/pull/9241#discussion_r1421374570
##########
mr/src/test/java/org/apache/iceberg/mr/hive/TestDeserializer.java:
##########
@@ -155,13 +155,13 @@ public void testListDeserialize() {
Object[] data = new Object[] {new Object[] {new LongWritable(1L)}};
Record actual = deserializer.deserialize(data);
- Assert.assertEquals(expected, actual);
+ assertThat(actual).isEqualTo(expected);
}
@Test
public void testDeserializeEverySupportedType() {
- Assume.assumeFalse(
- "No test yet for Hive3 (Date/Timestamp creation)",
HiveVersion.min(HiveVersion.HIVE_3));
+ assumeThat(HiveVersion.min(HiveVersion.HIVE_3))
+ .as("No test yet for Hive3 (Date/Timestamp creation)");
Review Comment:
this needs a `.isFalse()` at the end, otherwise it wouldn't anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
