GianlucaPrincipini commented on PR #9161: URL: https://github.com/apache/iceberg/pull/9161#issuecomment-1848794660
Hi @nastra, I migrated `TestIcebergInputFormats` in MR module, which is a slightly more complex test class than `TestDictionaryRowGroupFilter`. I found some other class that could be migrated to ParameterizedTestExtension, but that would imply major impacts on other modules, since some of these are coupled with common test logic and to their class hierarchy. In my opinion this implementation should be abstract enough to satisfy most needs. If you find there's need to migrate some more class let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
