GianlucaPrincipini commented on code in PR #9161:
URL: https://github.com/apache/iceberg/pull/9161#discussion_r1423154765


##########
api/src/test/java/org/apache/iceberg/TestHelpers.java:
##########
@@ -173,6 +178,60 @@ public static void assertSameSchemaMap(Map<Integer, 
Schema> map1, Map<Integer, S
         });
   }
 
+  /**
+   * A convenience method to avoid a large number of @Test(expected=...) tests
+   *
+   * @param message A String message to describe this assertion
+   * @param expected An Exception class that the Runnable should throw
+   * @param containedInMessage A String that should be contained by the thrown 
exception's message
+   * @param callable A Callable that is expected to throw the exception
+   */
+  public static void assertThrows(

Review Comment:
   I found that those were some duplicate `assertThrow` in parquet test utils 
package. I moved these duplicates in 833e9bff without noticing the deprecated 
ones. I fixed that in ea33322c50511cfc052a450f5833946d1112b636 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to