rdblue commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1421812643
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -46,8 +47,10 @@ private Types() {}
.put(DoubleType.get().toString(), DoubleType.get())
.put(DateType.get().toString(), DateType.get())
.put(TimeType.get().toString(), TimeType.get())
- .put(TimestampType.withZone().toString(), TimestampType.withZone())
- .put(TimestampType.withoutZone().toString(),
TimestampType.withoutZone())
+ .put(TimestampType.microsWithZone().toString(),
TimestampType.microsWithZone())
+ .put(TimestampType.microsWithoutZone().toString(),
TimestampType.microsWithoutZone())
Review Comment:
I don't think that the original lines need to change. We just need to add
nanoseconds. Otherwise the change is lager than it needs to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
