rdblue commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1421813424
##########
api/src/test/java/org/apache/iceberg/TestPartitionPaths.java:
##########
@@ -42,8 +42,8 @@ public void testPartitionPath() {
Transform<Integer, Integer> bucket = Transforms.bucket(10);
Literal<Long> ts =
-
Literal.of("2017-12-01T10:12:55.038194").to(Types.TimestampType.withoutZone());
- Object tsHour =
hour.bind(Types.TimestampType.withoutZone()).apply(ts.value());
+
Literal.of("2017-12-01T10:12:55.038194").to(Types.TimestampType.microsWithoutZone());
+ Object tsHour =
hour.bind(Types.TimestampType.microsWithoutZone()).apply(ts.value());
Review Comment:
Can you add a test for nanos? I think we also need identity tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
