deniskuzZ commented on code in PR #9301:
URL: https://github.com/apache/iceberg/pull/9301#discussion_r1426947971
##########
orc/src/main/java/org/apache/iceberg/orc/OrcIterable.java:
##########
@@ -134,7 +134,13 @@ private static VectorizedRowBatchIterator newOrcIterator(
try {
return new VectorizedRowBatchIterator(
- file.location(), readerSchema, orcFileReader.rows(options),
recordsPerBatch);
+ file.location(), readerSchema, orcFileReader.rows(options),
recordsPerBatch) {
+ @Override
+ public void close() throws IOException {
Review Comment:
`OrcIterable` also extends `CloseableGroup` and adds `orcFileReader` to
closeable, however, close() is called on `OrcRowIterator` and not
`OrcIterable`, leaving the `orcFileReader` open.
In case of `ParquetIterator` we close the reader.
````
public void close() throws IOException {
ParquetReader.close();
}
}
````
but that's not the case for `OrcIterable` that uses
`VectorizedRowBatchIterator`
````
@Override
public void close() throws IOException {
orcFileReader.rows(options).close();
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
