pvary commented on code in PR #9301:
URL: https://github.com/apache/iceberg/pull/9301#discussion_r1427579685


##########
orc/src/main/java/org/apache/iceberg/orc/OrcIterable.java:
##########
@@ -134,7 +134,13 @@ private static VectorizedRowBatchIterator newOrcIterator(
 
     try {
       return new VectorizedRowBatchIterator(
-          file.location(), readerSchema, orcFileReader.rows(options), 
recordsPerBatch);
+          file.location(), readerSchema, orcFileReader.rows(options), 
recordsPerBatch) {
+        @Override
+        public void close() throws IOException {

Review Comment:
   Based on this, I would think that this does not affect Apache Iceberg:
   
https://github.com/apache/iceberg/blob/c6bbbdbc11d42713c86dd52185f577b81d946963/gradle/libs.versions.toml#L71
   
   We use newer ORC version, which should contain ORC-498.
   
   Maybe we still miss something.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to