Fokko commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427150320
########## tests/integration/__init__.py: ########## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, Review Comment: I would agree with you, but it raises an error: ``` _____________________________________________________________________________ ERROR collecting tests/integration/test_hive.py ______________________________________________________________________________ import file mismatch: imported module 'test_hive' has this __file__ attribute: /Users/fokkodriesprong/Desktop/iceberg-python/tests/catalog/test_hive.py which is not the same as the test file we want to collect: /Users/fokkodriesprong/Desktop/iceberg-python/tests/integration/test_hive.py HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules _____________________________________________________________________________ ERROR collecting tests/integration/test_rest.py ______________________________________________________________________________ import file mismatch: imported module 'test_rest' has this __file__ attribute: /Users/fokkodriesprong/Desktop/iceberg-python/tests/catalog/test_rest.py which is not the same as the test file we want to collect: /Users/fokkodriesprong/Desktop/iceberg-python/tests/integration/test_rest.py HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules ``` We have the `__init__.py` files in the other folders as well 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
