HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427591155
########## tests/integration/__init__.py: ########## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, Review Comment: I raised this because we previously removed all `__init__.py` in tests: https://github.com/apache/iceberg/pull/5919 I think we can rename these two files to avoid name collisions with those in `catalogs/`. This would enable us to safely delete the `__init__.py` The other `__init__.py` in `tests/` was added in https://github.com/apache/iceberg-python/pull/45/. I removed this one and all tests still work. It would be ideal to maintain consistency by not having `__init__.py` files in test folders. However, I believe this is a minor issue and should not block this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
