amogh-jahagirdar commented on code in PR #9247:
URL: https://github.com/apache/iceberg/pull/9247#discussion_r1427357997
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -200,6 +200,13 @@ public void completeCreateView() {
.build())
.build());
+ assertThat(((SQLViewRepresentation) view.sqlFor("spark")).sql())
+ .isEqualTo("select * from ns.tbl");
+ assertThat(((SQLViewRepresentation) view.sqlFor("trino")).sql())
+ .isEqualTo("select * from ns.tbl using X");
+ assertThat(((SQLViewRepresentation) view.sqlFor("unknown-dialect")).sql())
+ .isEqualTo("select * from ns.tbl using X");
Review Comment:
I added 2 new tests. We actually don't need to worry about the "non-sql"
case because we prevent writing out that metadata anyways (I forgot we
implemented that), which makes sense since there is no defined type other than
SQL in the spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
