rdblue commented on code in PR #9247:
URL: https://github.com/apache/iceberg/pull/9247#discussion_r1427362141
##########
core/src/main/java/org/apache/iceberg/view/BaseView.java:
##########
@@ -103,4 +105,29 @@ public UpdateLocation updateLocation() {
public UUID uuid() {
return UUID.fromString(ops.current().uuid());
}
+
+ /**
+ * This implementation of sqlFor will resolve what is considered the
"closest" dialect. If an
+ * exact match is found, then that is returned. Otherwise, the first
representation would be
+ * returned. If no SQL representation is found, null is returned.
+ */
+ @Override
+ public SQLViewRepresentation sqlFor(String dialect) {
+ Preconditions.checkArgument(dialect != null, "Invalid dialect: null");
+ Preconditions.checkArgument(!dialect.isEmpty(), "Invalid dialect: empty");
Review Comment:
Nit: it might be a bit more clear if you use parens, like `(empty string)`
here so no one thinks the dialect was `"empty"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
